0008549: message envelope not passed to php mailer, phpmailer does not set the correct Sender

(0021411)
hola (reporter)
26-11-06 21:02

hello - I am not sure why you are adding the new logic to phpmailer - if you look at the conditional that would invoke the code you changed the else is dealing with the Sender param not being sent

if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1)

(0021765)
danieleint (reporter)
06-12-06 15:36

Hellp, hola is right.
The patch should be valid for the file lists/admin/lib.php

(0022107)
michiel (administrator)
18-12-06 17:43

the use of ini_set("sendmail_from", $this->Sender);
in your patch suggests you're working on a windows system.
That makes it harder to test for me to see that it works.

So, am I correct to understand that you think that changing

if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1)

in lib.php will fix it instead?

(0022112)
hola (reporter)
18-12-06 20:06

hmmm that code you mention Michiel was already in the phpmailer class - I doubled checked on your 2.10.3 release and here it is below

if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1)
        {
            $old_from = ini_get("sendmail_from");
            ini_set("sendmail_from", $this->Sender);
            $params = sprintf("-oi -f %s", $this->Sender);
            $rt = @mail($to, $this->EncodeHeader($this->Subject), $body,
                        $header, $params);
        }
        else
            $rt = @mail($to, $this->EncodeHeader($this->Subject), $body, $header);

(0022113)
hola (reporter)
18-12-06 20:07

Can you please highlight why this would be an issue on non-windows platforms as I am running phplist on Linux

(0022116)
michiel (administrator)
18-12-06 20:28

well, I don't get the problem on Linux at all, so to get it fixed, someone with windows will have to figure out how to fix it.

(0022117)
hola (reporter)
18-12-06 20:32

I don't even know what the problem is with phpmailer. I was just commenting on the fact that phpmailer already had the set_ini. I think I am missing something here... I will just watch from now on.

(0029870)
bas (developer)
30-07-07 16:01

envelope included in mail object construction of PHPListMailer
Second patch was already like this.
This issues report is quite confusing, try to be more clear:
• What did you do (incl. platform)
• What did you expect
• What did you get

Notes
(0021411) hola (reporter) 26-11-06 21:02	hello - I am not sure why you are adding the new logic to phpmailer - if you look at the conditional that would invoke the code you changed the else is dealing with the Sender param not being sent if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1)

(0021765) danieleint (reporter) 06-12-06 15:36	Hellp, hola is right. The patch should be valid for the file lists/admin/lib.php

(0022107) michiel (administrator) 18-12-06 17:43	the use of ini_set("sendmail_from", $this->Sender); in your patch suggests you're working on a windows system. That makes it harder to test for me to see that it works. So, am I correct to understand that you think that changing if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1) in lib.php will fix it instead?

(0022112) hola (reporter) 18-12-06 20:06	hmmm that code you mention Michiel was already in the phpmailer class - I doubled checked on your 2.10.3 release and here it is below if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1) { $old_from = ini_get("sendmail_from"); ini_set("sendmail_from", $this->Sender); $params = sprintf("-oi -f %s", $this->Sender); $rt = @mail($to, $this->EncodeHeader($this->Subject), $body, $header, $params); } else $rt = @mail($to, $this->EncodeHeader($this->Subject), $body, $header);

(0022113) hola (reporter) 18-12-06 20:07	Can you please highlight why this would be an issue on non-windows platforms as I am running phplist on Linux

(0022116) michiel (administrator) 18-12-06 20:28	well, I don't get the problem on Linux at all, so to get it fixed, someone with windows will have to figure out how to fix it.

(0022117) hola (reporter) 18-12-06 20:32	I don't even know what the problem is with phpmailer. I was just commenting on the fact that phpmailer already had the set_ini. I think I am missing something here... I will just watch from now on.

(0029870) bas (developer) 30-07-07 16:01	envelope included in mail object construction of PHPListMailer Second patch was already like this. This issues report is quite confusing, try to be more clear: • What did you do (incl. platform) • What did you expect • What did you get