0008457: $bounce_unsubscribe_t[h]reshold problem upgrading from 2.10.2 to 2.10.3

Create

Capture

Maintain

Audience

View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0008457

phplist

Bounce Management

public

07-11-06 15:08

18-02-08 14:06

Reporter

orock

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

2.10.3

Target Version

2.10.7

Fixed in Version

2.10.4

Summary

0008457: $bounce_unsubscribe_t[h]reshold problem upgrading from 2.10.2 to 2.10.3

Description

we made an unknowing mistake when upgrading from 2.10.2 to 2.10.3 of copying lines from our previous config.php to the new one.

we ended up with:
$bounce_unsubscribe_treshold = 5;

instead of:
$bounce_unsubscribe_threshold = 5;

this caused our users to be unconfirmed on their first bounce since $bounce_unsubscribe_threshold is unset.

i noticed in admin/init.php some code attempting to correct this spelling error in previous version but it is incorrect and will never kick in.

the code reads:

## spelling mistake in earlier version, make sure to set it correctly
if (!isset($bounce_unsubscribe_threshold) && isset($bounce_unsubscribe_threshold)) {
$bounce_unsubscribe_threshold = $bounce_unsubscribe_treshold;
}

this checks if the correct value ($bounce_unsubscribe_threshold) IS NOT SET and whether the correct value ($bounce_unsubscribe_threshold) IS SET. this will obviously never be true and clearly should be a check for correct value ($bounce_unsubscribe_threshold) NOT SET and for incorrect value ($bounce_unsubscribe_treshold) SET.

we have fixed the problem by correcting the spelling in the config.php file but this was confounding us for a while be cause $bounce_unsubscribe_threshold looks soooo much like $bounce_unsubscribe_treshold.

Notes
(0020748) michiel (administrator) 07-11-06 15:11	my head spins as well, and obviously did when I was trying to set the workaround. Thanks for finding that

(0020752) orock (reporter) 07-11-06 16:09	glad to help.