largersmallernormaltext version of this page

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005476phplistAll Otherpublic15-02-06 00:4518-02-08 14:19
Reporterosoell 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product Version 
Target Version2.11.XFixed in Version 
Summary0005476: USE_MANUAL_TEXT_PART and content from [URL:<url>]
DescriptionWhen using the USE_MANUAL_TEXT_PART option, urls do not get replaced into the content.
Additional Informationhere is a patch to sendemaillib.php. It's not great, but it works. I am still getting familiar with how phplist works internally. It is really just reusing a block which did the html portion, but comments out one line. I'm sure this could just get better integrated and use a while loop for the html and text portions, but there are also a bunch of conditional blocks that I wasn't sure about. I have made a few other changes in this file so the line numbers probably won't match up.

TagsNo tags attached.
Attached Filespatch file icon manual_text_part.patch [^] (1,150 bytes) 15-02-06 00:45 [Show Content]

- Relationships
related to 0005878resolvedmichiel html parses the text before adding the UniqID; in plain text, it doesn't add the UniqID at all 
related to 0002705closed PHPList v2.11 release 
has duplicate 0005455closed Failure to replace Placeholders in TEXT versions of HTML/TEXT emails 
related to 0013662new Provide option to edit textmessage after automatic generation from html 

-  Notes
(0010689)
osoell (reporter)
15-02-06 00:48

sorry, forgot to mention again - 2.10.2.
(0010833)
bevan (reporter)
18-02-06 18:09

Thanks!!
(0013167)
michiel (administrator)
28-04-06 03:51

that's an interesting problem.

Basically, the "send a webpage" system, expects the content to be all HTML, as you are sending a webpage. So it fetches the content before converting to text. If you were to add the URL: bit to the text, you'd have to convert it to text afterwards.

Now the problem with your patch is "user parameters". You are caching the result in memory, but that will cause problems, when a URL is used like http://website/script.php?email=[email] [^]

in this case the email is passed onto the URL and therefore the content may change. With your patch this would be applied to all subsequent users, which is not what we'd want.

Basically for now, I'd advice when using URL, send a webpage to only use the HTML version of the email and the resulting text email will be parsed out of that.

If I were to add support for the text version of an email to have "send a webpage", I would probably want to restrict the URL that is requested to be "text/plain", so that there is no need to parse it back into text from HTML.

I'm afraid I will mark this for the dev-version, and we'll see where it goes from there. I don't consider this a bugfix, so it won't get into 2.10.x


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker