0015325: SMTP code is partially broken (revisited)

Create

Capture

Maintain

Audience

View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015325

phplist

Message Send Process

public

01-09-09 22:08

20-04-10 02:09

Reporter

h2b2

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

2.10.10

Target Version

2.10.12

Fixed in Version

2.10.12

Summary

0015325: SMTP code is partially broken (revisited)

Description

cipixul reports that the code changes applied to "admin/class.phplistmailer.php" in order to fix issue 8590 can result in trouble:

===== Start Quote =====

The code is wrong because it uses PHPMAILERHOST only if the admin set phpmailer_user, which is not always the case, and as we run several smtpd servers on same machine, we don't authenticate to our smtpd instances because they're local.

===== End Quote =====
Source: http://forums.phplist.com/viewtopic.php?f=17&t=23830#p67628 [^]

Additional Information

cipixul suggests the following changes to fix the issue:

===== Start Quote =====

The correct code which works in our case and in all other cases I can think of should be this one:

          if (defined('PHPMAILERHOST') && PHPMAILERHOST != '')
          {
            //logEvent('Sending authenticated email via '.PHPMAILERHOST);
            //$this->addCustomHeader("X-Mailer-Method: Dedicated SMTP");
            $this->SMTPAuth = true;
            $this->Helo = getConfig("website");
            $this->Host = PHPMAILERHOST;
            if ( isset($GLOBALS['phpmailer_smtpuser']) && $GLOBALS['phpmailer_smtpuser'] != ''
                    && isset($GLOBALS['phpmailer_smtppassword']) && $GLOBALS['phpmailer_smtppassword']
            )
            {
                    $this->Username = $GLOBALS['phpmailer_smtpuser'];
                    $this->Password = $GLOBALS['phpmailer_smtppassword'];
            }
            $this->Mailer = "smtp";
          }

===== End Quote =====

Related to: http://mantis.phplist.com/view.php?id=8590 [^]
Related forum thread: http://forums.phplist.com/viewtopic.php?f=17&t=23830#p67628 [^]

Notes
(0050766) h2b2 (manager) 01-11-09 17:42	related to http://mantis.phplist.com/view.php?id=15291 [^]