0015275: stripHTML is too greedy when matching links

Create

Capture

Maintain

Audience

View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015275

phplist

HTML Email Support

public

04-05-09 12:11

03-05-10 18:16

Reporter

mcfang

Priority

normal

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

2.10.9

Target Version

Fixed in Version

2.10.10

Summary

0015275: stripHTML is too greedy when matching links

Description

If your HTML has any A tags that do not have a HREF attribute then entire blocks of text are deleted.

A tags are most commonly used without HREF when providing anchor links within the content. eg: <a name="top"></a>

The problem is caused by a greedy match in function stripHTML (sendemaillib.php:1134)

$text = preg_replace("/<a.*href=[\"\'](.*)[\"\'][^>]*>(.*)<\/a>/Umis","[URLTEXT]\\2[ENDURLTEXT][LINK]\\1[ENDLINK]\n",$text);

If we replace the first greedy match with a saner match it will not be a problem:

$text = preg_replace("/<a[^>]*href=[\"\'](.*)[\"\'][^>]*>(.*)<\/a>/Umis","[URLTEXT]\\2[ENDURLTEXT][LINK]\\1[ENDLINK]\n",$text);

Tags

No tags attached.

Attached Files

Relationships

related to	0015193	new		Portions of Content are Omitted in Plain Text from Plain Text Messages with <a> Tag
related to	0009105	feedback	michiel	Anchors in HTML get converted to links in text mails

Notes
There are no notes attached to this issue.