0015235: Accept more $_GET parameters in subscribelib2.php

Create

Capture

Maintain

Audience

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0015235

[phplist] Subscribe Process

feature

always

18-02-09 13:37

12-08-09 09:34

Reporter

lwc

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

2.11.2-RC1

Summary

0015235: Accept more $_GET parameters in subscribelib2.php

Description

You already accept $_REQUEST['email'] and $_REQUEST['emailconfirm'] so there's no reason not accept defaults via $_GET parameters for the other two fields:

1) Allow ?p=subscribe&list[x]=signup

function ListAvailableLists...

  if (isset($_POST['list'])) {
    $list = $_POST["list"];
// custom code - start
  } elseif (!isset($_POST["subscribe"]) && isset($_GET['list'])) {
    $list = $_GET["list"];
// custom code - end
  } else...

2) Allow ?p=subscribe&htmlemail=1

function ListAttributes...

    if (isset($_POST['htmlemail'])) {
      $htmlemail = $_POST["htmlemail"];
// custom code - start
    } elseif (!isset($_POST["subscribe"]) && isset($_GET['htmlemail'])) {
      $htmlemail = $_GET["htmlemail"];
// custom code - end
    }

Additional Information

Note that you should NOT under any cirumstances "just" use $_REQUEST for "list" and "htmlemail" because it would turn them into required fields!

That's why this request also fixes request 11011

Tags

No tags attached.

Attached Files

Relationships

related to	0011011	closed		Preselection of one, all or some lists per subscribe-page url
related to	0015236	new		Support for defining a default for "htmlemail"

Notes
(0050506) lwc (reporter) 18-02-09 13:38	Please add relationship to 0011011

(0050712) lwc (reporter) 12-08-09 09:34	Here's a more complicated but much more friendly solution for 1): 1) Allow ?p=subscribe&list=x,y,z (or just list=x) function ListAvailableLists... if (isset($_POST['list'])) { $list = $_POST["list"]; // custom code - start } elseif (!isset($_POST["subscribe"]) && isset($_GET['list'])) { $list_value = "signup"; $list_values = explode(",", $_GET["list"]); if (function_exists(array_fill_keys)) // Only in PHP 5+ $list = array_fill_keys($list_values, $list_value); else // For PHP 4, per phplist's current system requirements foreach($list_values as $key=>$value) $list[$value] = $list_value; // custom code - end } else...