0013804: Keeping criterias during message edits (revisited)

Create

Capture

Maintain

Audience

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0013804

[phplist] Message Management

minor

N/A

20-03-08 07:47

25-04-08 12:55

Reporter

rolan

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

2.10.4

Summary

0013804: Keeping criterias during message edits (revisited)

Description

selected criteria values are not displayed between message edits.
This is related to issue #3608

Additional Information

This is not a thorough patch. It's a hack that will work if there is only one checkboxgroup type criteria. Perhaps someone can take it further?

The user interface is no longer intuitive in that you can't remove critera by simply unchecking "Use this one []." Also, the radio button can not be unselected if there is only 1 critera option. The only way to remove a checkboxgroup/selection list is to unselect all the options then click "Save Changes"

I'm guessing the future of phplist criteria management is the stacked method, however, there is a lot to be desired with the current stacked implementation.

Tags

No tags attached.

Attached Files

send_core.php.diff [^] (3,469 bytes) 20-03-08 07:47

import1.php.diff [^] (813 bytes) 24-04-08 18:10

Relationships

Notes
(0044114) alfredo_tripicchio (reporter) 03-04-08 14:22	I applied the patch send_core.php.diff to version 2.10.5 and it worked. But it works only for checkboxgroup attributes. Also I understand that simple criteria will be no longer supported, so I turned STACKED_ATTRIBUTE_SELECTION on and I found out it does not work for select attributes. In the end I recovered the original script and fixed it adding this line: $crit_data["values"] = ltrim($crit_data["values"], ','); just before this one in send_core.php (line 788): $where_clause .= $crit_data["values"] . ") )"; It works for me, but I checked it only for a select attribute and with the advanced criteria selection.

(0045814) rolan (reporter) 24-04-08 18:12	"import emails with the same values for attributes" feature was failing because it would insert "Array" in the "value" column instead of the actual attribute id's in table phplist_user_user_attribute

(0045815) rolan (reporter) 24-04-08 18:12	... so a small change had to be made to import1.php

(0045843) julian (reporter) 25-04-08 12:55	Related to: http://mantis.phplist.com/view.php?id=3608 [^] http://mantis.phplist.com/view.php?id=4103 [^] Mentioned in the forums: http://forums.phplist.com/viewtopic.php?t=16684&highlight=criteria [^]